From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: qcom: Switch to generic PAS TZ APIs Date: Fri, 13 Mar 2026 14:26:34 +1000 Message-ID: In-Reply-To: <20260312062756.694390-12-sumit.garg@kernel.org> References: <20260312062756.694390-1-sumit.garg@kernel.org> <20260312062756.694390-12-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Mostly clean. Notable behavioral change: `iris_set_hw_state()` now passes `core->iris_platform_data->pas_id` instead of hardcoded `0`: ```c return qcom_pas_set_remote_state(resume, core->iris_platform_data->pas_id); ``` And `venus_set_hw_state()` now passes `VENUS_PAS_ID` instead of `0`: ```c ret = qcom_pas_set_remote_state(resume, VENUS_PAS_ID); ``` The commit message acknowledges this: "the SCM backend just ignores it while OP-TEE makes use of it." This is a reasonable fix but it's a functional change mixed in with the API migration. Some reviewers might prefer this in a separate patch. --- Generated by Claude Code Patch Reviewer