From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Bump the driver version to 1.8 Date: Sat, 14 Mar 2026 06:48:47 +1000 Message-ID: In-Reply-To: <20260313150956.1618635-12-adrian.larumbe@collabora.com> References: <20260313150956.1618635-1-adrian.larumbe@collabora.com> <20260313150956.1618635-12-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward version bump. Note this is numbered 11/11 in the subject but appears before patch 10 in the mbox ordering -- this is just mbox delivery ordering, not a logical concern. --- **Summary of actionable issues:** 1. **Critical (UAPI):** Patch 1 inserts `DRM_PANTHOR_DEV_QUERY_MMU_INFO` in the middle of the enum, shifting existing values. Must be appended at the end. 2. **Bug:** Patch 8 `panthor_vm_repeated_map_pages` error path uses `size * (i - 1)` which is wrong -- should be `size * i`. 3. **Dead code:** Patch 5 adds `sm_can_merge_flags` callback to `drm_gpuvm_ops` but it's never used. 4. **Minor:** `DRM_GPUVM_HAS_REPEAT_MAPS` is never cleared when all repeat mappings are removed. --- Generated by Claude Code Patch Reviewer