From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Apply drm_bridge_connector helper Date: Sun, 22 Mar 2026 04:35:47 +1000 Message-ID: In-Reply-To: <20260319071452.1961274-12-damon.ding@rock-chips.com> References: <20260319071452.1961274-1-damon.ding@rock-chips.com> <20260319071452.1961274-12-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the core patch of the series. Key changes: 1. **Connector funcs =E2=86=92 bridge funcs migration**: `analogix_dp_get_m= odes` =E2=86=92 `analogix_dp_bridge_get_modes`, `analogix_dp_detect` =E2=86= =92 `analogix_dp_bridge_detect`, `analogix_dp_atomic_check` =E2=86=92 `anal= ogix_dp_bridge_atomic_check`. All correctly adapted to bridge function sign= atures. 2. **NO_CONNECTOR enforcement**: The attach function now *requires* `DRM_BR= IDGE_ATTACH_NO_CONNECTOR` =E2=80=94 the private connector is gone. 3. **Bridge connector init**: Both Rockchip and Exynos sides now create the= connector via `drm_bridge_connector_init()`. 4. **CRC functions**: `analogix_dp_start_crc` and `analogix_dp_stop_crc` no= w get the `dp` pointer via `drm_bridge_chain_get_first_bridge()` instead of= `container_of` from the connector. The `bridge->type !=3D DRM_MODE_CONNECT= OR_eDP` check is a reasonable sanity guard. 5. **Bridge ops**: Set to `DRM_BRIDGE_OP_MODES | DRM_BRIDGE_OP_DETECT` for = panels, `DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT` for non-panels. One observation: `connector->funcs->destroy(&dp->connector)` removal from `= analogix_dp_unbind()` is correct since the connector no longer exists in th= e analogix_dp_device struct. No blocking issues. --- Generated by Claude Code Patch Reviewer