From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Date: Sun, 22 Mar 2026 04:07:13 +1000 Message-ID: In-Reply-To: <20260319223241.1351137-12-vladimir.oltean@nxp.com> References: <20260319223241.1351137-1-vladimir.oltean@nxp.com> <20260319223241.1351137-12-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces `hdmi->phy->dev.of_node` with DT phandle lookup using `of_property_match_string()` + `of_parse_phandle_with_args()`. This is a clean approach. Key change at line 3854: ```c if (!of_parse_phandle_with_args(np, "phys", "#phy-cells", index, &clkspec)) { hdmi->hdmiphy_clk = of_clk_get_from_provider(&clkspec); of_node_put(clkspec.np); ``` Good: adds `of_node_put(clkspec.np)` which the original code was missing (the old code used `hdmi->phy->dev.of_node` which doesn't need a put since it's borrowed). The behavioral change from checking `if (hdmi->phy)` to `if (index >= 0)` is correct since if the PHY was found by name "hdmi", the index will be valid. --- Generated by Claude Code Patch Reviewer