From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ast: Gen2: Fix open-coded register access
Date: Wed, 25 Mar 2026 07:46:41 +1000
Message-ID: <review-patch11-20260323160407.245773-12-tzimmermann@suse.de>
In-Reply-To: <20260323160407.245773-12-tzimmermann@suse.de>
References: <20260323160407.245773-1-tzimmermann@suse.de> <20260323160407.245773-12-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Good cleanup. The FIXME comment about MCR04[5:4] is a worthwhile observation:
```c
/*
 * FIXME: There might be bits already in MCR04[5:4]. Should
 *        we only do this in the default case?
 */
scu070 = ast_mindwm(ast, AST_REG_SCU070);
mcr04 |= (scu070 & GENMASK(3, 2)) << 2;
```

The `ast_moutdwm_poll` calls for SCU and MCR unlock correctly replace the old manual segment setup + busy-wait patterns.

---
Generated by Claude Code Patch Reviewer