From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Date: Sun, 12 Apr 2026 13:37:35 +1000 Message-ID: In-Reply-To: <20260407-drm-lcdif-dbanc-v4-11-247a16e61ef9@bootlin.com> References: <20260407-drm-lcdif-dbanc-v4-0-247a16e61ef9@bootlin.com> <20260407-drm-lcdif-dbanc-v4-11-247a16e61ef9@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The core change of the series: ```c - ret = drm_bridge_attach(encoder, bridge, NULL, 0); + ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); ... + connector = drm_bridge_connector_init(lcdif->drm, encoder); + if (IS_ERR(connector)) + return dev_err_probe(dev, PTR_ERR(connector), + "Failed to init bridge_connector for endpoint%u\n", + of_ep.id); + + ret = drm_connector_attach_encoder(connector, encoder); ``` This follows the standard bridge-connector pattern correctly. The Kconfig additions of `DRM_DISPLAY_HELPER` and `DRM_BRIDGE_CONNECTOR` are necessary. The commit message's analysis of the three LCDIF pipelines and their bridge compatibility is thorough and appreciated. **Minor typos in commit message**: "surrently" should be "currently", "amd" should be "and". No functional issues. --- Generated by Claude Code Patch Reviewer