From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915: Implement the "color format" DRM property
Date: Sun, 12 Apr 2026 11:01:42 +1000 [thread overview]
Message-ID: <review-patch11-20260409-color-format-v12-11-ce84e1817a27@collabora.com> (raw)
In-Reply-To: <20260409-color-format-v12-11-ce84e1817a27@collabora.com>
Patch Review
Full i915 implementation. Renames existing `compute_formats` to `compute_formats_auto`, adds a new `compute_formats` dispatcher:
```c
switch (conn_state->color_format) {
case DRM_CONNECTOR_COLOR_FORMAT_RGB444:
return intel_dp_compute_output_format(encoder, crtc_state, conn_state,
respect_downstream_limits,
INTEL_OUTPUT_FORMAT_RGB);
case DRM_CONNECTOR_COLOR_FORMAT_YCBCR444:
return intel_dp_compute_output_format(encoder, crtc_state, conn_state,
respect_downstream_limits,
INTEL_OUTPUT_FORMAT_YCBCR444);
case DRM_CONNECTOR_COLOR_FORMAT_YCBCR420:
...
```
**Notes**:
1. i915 registers with RGB444|YCBCR444|YCBCR420 -- **no YUV422**. This is a deliberate omission (not all Intel hardware supports YUV422 output). This is the correct approach -- only advertise what the source can do.
2. The `MISSING_CASE(conn_state->color_format)` in the default case is idiomatic i915 style. Good.
3. The `YCBCR422` case is absent from the switch, so if userspace tries to set it, the `MISSING_CASE` default will fire. But since YUV422 is not in the property's enum list, userspace can't actually set it. Correct.
4. Both HDMI and DP paths use the same dispatcher pattern. Clean.
**Verdict**: Good.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 1:01 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 15:44 [PATCH v12 00/25] Add new general DRM property "color format" Nicolas Frattaroli
2026-04-09 15:44 ` [PATCH v12 01/25] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 02/25] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 03/25] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 04/25] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-04-09 22:08 ` Dmitry Baryshkov
2026-04-10 14:21 ` Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 05/25] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-04-09 22:09 ` Dmitry Baryshkov
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 06/25] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 07/25] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 08/25] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 ` [PATCH v12 09/25] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 10/25] drm/i915/dp: " Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 11/25] drm/i915: Implement the "color format" DRM property Nicolas Frattaroli
2026-04-12 1:01 ` Claude Code Review Bot [this message]
2026-04-09 15:45 ` [PATCH v12 12/25] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 13/25] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 14/25] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 15/25] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 16/25] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 17/25] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 18/25] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 19/25] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-04-09 22:09 ` Dmitry Baryshkov
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 20/25] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 21/25] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 22/25] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 23/25] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 24/25] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-09 15:45 ` [PATCH v12 25/25] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-04-12 1:01 ` Claude review: Add new general DRM property "color format" Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 16:01 [PATCH v11 00/22] " Nicolas Frattaroli
2026-03-24 16:01 ` [PATCH v11 08/22] drm/i915: Implement the "color format" DRM property Nicolas Frattaroli
2026-03-24 20:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch11-20260409-color-format-v12-11-ce84e1817a27@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox