From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Wire drmm_connector_dp_init() via new DRM_BRIDGE_OP_DP flag Date: Sun, 12 Apr 2026 10:51:26 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-11-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-11-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Structurally fine. The priority ordering (HDMI checked before DP) is reasonable. Minor: adding `dp_link_train_caps` pointer to `struct drm_bridge` increases the struct size for all bridges. This is a small cost (~8 bytes on 64-bit) but worth noting. An alternative would be to look it up only when `DRM_BRIDGE_OP_DP` is set, but the current approach is simpler. The validation in `drm_bridge_connector_init()` (checking for duplicate DP ops and NULL caps) is good. --- Generated by Claude Code Patch Reviewer