From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: vbios: use the first PCI-AT and FWSEC images Date: Thu, 23 Apr 2026 08:42:26 +1000 Message-ID: In-Reply-To: <20260421-fix-vbios-v3-11-8f648aef7a85@nvidia.com> References: <20260421-fix-vbios-v3-0-8f648aef7a85@nvidia.com> <20260421-fix-vbios-v3-11-8f648aef7a85@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Behavioral change to align with nouveau. Previously, PCI-AT would be overwritten by later images; now the first one is kept. For FWSEC, the old code could overwrite `second_fwsec_image` if more than two existed; now extras beyond the first two are silently ignored. The commit message says "align to nouveau behavior" which is reasonable justification. The "silently ignore" approach was chosen in v3 over v2's "error on duplicates" approach, which seems pragmatic. **Minor observation:** This patch lacks a `Reviewed-by` from Joel, unlike most others in the series. Not a blocking issue, but worth noting the v3 changelog says the change from erroring to using the first image was new in v3. --- **Summary:** Series looks good. The one minor concern is the unchecked subtraction in the `else` branch of patch 9 (`offset - first_fwsec.base.data.len()`) which, while safe due to the preceding condition, is inconsistent with the defensive style advocated by the rest of the series. Consider using `checked_sub` or at minimum adding a comment noting the safety argument. --- Generated by Claude Code Patch Reviewer