From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: qcom: Switch to generic PAS TZ APIs Date: Tue, 28 Apr 2026 14:49:24 +1000 Message-ID: In-Reply-To: <20260427095603.1157963-12-sumit.garg@kernel.org> References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-12-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good migration. Notable behavioral change: `iris_set_hw_state()` previously passed `0` as the PAS ID to `qcom_scm_set_remote_state()`, and now passes `core->iris_platform_data->pas_id`. Similarly, venus passes `VENUS_PAS_ID` instead of `0`. The commit message explains this: "the SCM backend just ignores it while OP-TEE makes use of it." This is correct but is a real functional change, not just a rename. The Kconfig whitespace fix (spaces to tabs) in the iris Kconfig is a drive-by cleanup. It's fine but could have been a separate patch for bisectability. --- Generated by Claude Code Patch Reviewer