From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: pci: make Driver trait lifetime-parameterized Date: Tue, 28 Apr 2026 13:47:57 +1000 Message-ID: In-Reply-To: <20260427221155.2144848-12-dakr@kernel.org> References: <20260427221155.2144848-1-dakr@kernel.org> <20260427221155.2144848-12-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The core conversion pattern for PCI. `Adapter` becomes `Adapter` with `for<'a> F::Of<'a>: Driver<'a>`. The probe callback now uses ` as Driver<'_>>::probe(pdev, info)` -- the turbofish syntax is verbose but necessary. The `module_pci_driver!` macro change from `($($f:tt)*)` to `(type: $type:ty, $($rest:tt)*)` is a breaking change but needed to wrap the type in `ForLt!()`. This is consistent across all bus types. In `probe_callback`, `info` is now looked up inside `from_result(|| { ... })` rather than outside. This is important -- it ensures the `info` borrow lifetime matches the callback scope. ### PATCHES 12-13: platform and auxiliary Driver trait lifetime-parameterized Follow the same pattern as PCI patch 11. No additional concerns. --- Generated by Claude Code Patch Reviewer