From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: rockchip: dw-dp: fix sound DAI cells Date: Tue, 05 May 2026 09:49:48 +1000 Message-ID: In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-11-d7e7f6bac77f@collabora.com> References: <20260501-synopsys-dw-dp-improvements-v2-0-d7e7f6bac77f@collabora.com> <20260501-synopsys-dw-dp-improvements-v2-11-d7e7f6bac77f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Changes `#sound-dai-cells` from 0 to 1 to allow selecting I2S vs SPDIF. **This is an ABI break** =E2=80=94 existing DTs have `#sound-dai-cells =3D = <0>` and references like `sound-dai =3D <&dp0>`. Changing to 1 cell means a= ll existing sound references would need updating. The commit message discus= ses MST considerations well. The `description: 0 for I2S, 1 for SPDIF` should be in the binding's descri= ption for the `#sound-dai-cells` property, not just as a bare description l= ine. Also, since this is an existing ABI change, it needs more consideratio= n about backwards compatibility (e.g., supporting both 0 and 1 cells in the= driver). --- Generated by Claude Code Patch Reviewer