From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Date: Tue, 05 May 2026 08:26:10 +1000 Message-ID: In-Reply-To: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-11-b578c3daaf10@bootlin.com> References: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-0-b578c3daaf10@bootlin.com> <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-11-b578c3daaf10@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** Now that all bridge-only callers have been converted, this patch: 1. Adds `WARN_ON(!panel)` to catch any remaining or new bridge-only callers 2. Simplifies the code by removing the `if (panel)` guards (since panel is = now mandatory) 3. Updates the kdoc to reflect `@panel` must not be NULL and recommends `of= _drm_get_bridge_by_endpoint()` for bridge-only lookups The `if (bridge)` guard is kept since `@bridge` is still optional (callers = that only want a panel can pass `NULL` for bridge). The kdoc change is clea= r and the code simplification is correct. --- **Summary:** The series is in good shape. The only blocking issue is the `r= eturn -ENODEV;` =E2=86=92 `return ERR_PTR(-ENODEV);` fix needed in the non-= OF stub in patch 2. Everything else looks correct, with consistent conversi= on patterns and proper refcount handling throughout. --- Generated by Claude Code Patch Reviewer