From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Date: Sat, 16 May 2026 15:02:25 +1000 Message-ID: In-Reply-To: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-11-f61c9e498b3f@bootlin.com> References: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-0-f61c9e498b3f@bootlin.com> <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-11-f61c9e498b3f@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good final cleanup. The `WARN_ON(!panel)` serves as both a runtime check and documentation that bridge-only callers must use `of_drm_get_bridge_by_endpoint()` instead: ```c - if (!panel && !bridge) + if (WARN_ON(!panel)) return -EINVAL; ``` The code simplification that follows (removing `if (panel)` guards) is a clean consequence. The function still correctly handles the `bridge == NULL` case for panel-only callers, and the `panel != NULL, bridge != NULL` case for dual-use callers. The updated kdoc correctly points developers to the right replacement APIs. No issues. --- Generated by Claude Code Patch Reviewer