From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: uvesafb: fix potential memory leak in uvesafb_probe() Date: Sat, 16 May 2026 11:10:42 +1000 Message-ID: In-Reply-To: <20260514-fbdev-v1-11-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> <20260514-fbdev-v1-11-b3a2474fa720@cse.iitm.ac.in> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Correct** This is the most interesting fix in the series. Instead of adding a new cle= anup call, it fixes incorrect `goto` labels: ```c - goto out; + goto out_mode; ``` I verified in the source tree that `out_mode` (at line 1759) performs model= ist destruction, modedb destruction, and cmap deallocation, while `out` (at= line 1764) only frees `par->vbe_modes` and releases the framebuffer. Since= `uvesafb_vbe_init()` populates the modelist and modedb before these error = points, the `goto out` was indeed skipping necessary cleanup. The fix to `g= oto out_mode` is correct. Note: calling `fb_dealloc_cmap()` at `out_mode` when `fb_alloc_cmap()` hasn= 't been called yet (in the `uvesafb_vbe_init_mode()` failure case) is safe = =E2=80=94 `fb_dealloc_cmap()` handles uninitialized cmaps gracefully. --- --- Generated by Claude Code Patch Reviewer