From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: moduleparam: Drop legacy kernel_param_ops .get_str field and dispatch logic Date: Mon, 25 May 2026 20:11:18 +1000 Message-ID: In-Reply-To: <20260521133326.2465264-11-kees@kernel.org> References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-11-kees@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean removal of the migration scaffolding: drops `.get_str`, removes the `= _Generic` routing macros, simplifies `DEFINE_KERNEL_PARAM_OPS` back to dire= ct assignment, and removes the dual-path dispatch in `param_attr_show()` an= d `param_array_get()`. The `param_array_get` simplification is notable =E2=80=94 the bounce buffer= allocation and `.get_str` fallback are gone, leaving only the clean `arr->= ops->get(s, &p)` path. **Verdict: Clean teardown. The final state is simpler than what existed bef= ore the series.** --- **Summary for DRM maintainers**: The DRM-relevant changes are in patches 4 = (converting `drm_panic.c` and `i915_mitigations.c` `kernel_param_ops` initi= alizers to `DEFINE_KERNEL_PARAM_OPS` macro), 9 (`drm_panic.c` callback sign= ature change), and 10 (`i915_mitigations.c` manual callback conversion). Al= l three are straightforward and correct. The series should be acked for DRM. --- Generated by Claude Code Patch Reviewer