From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/hdmi: Add YCBCR444 handling for sink formats Date: Mon, 25 May 2026 18:48:55 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-11-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-11-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The `intel_hdmi_can_ycbcr444` function: ```c static bool intel_hdmi_can_ycbcr444(struct intel_connector *connector) { const struct intel_display *display =3D to_intel_display(connector); if (HAS_GMCH(display)) return true; return false; } ``` **This looks inverted.** `HAS_GMCH` is true for older platforms (pre-Ironla= ke). The function says "GMCH platforms can do YCbCr444, nothing else can." = But typically GMCH platforms are *less* capable, and modern platforms (whic= h have display engines, not GMCH) are more capable. The existing `intel_hdm= i_sink_bpc_possible` for 12bpc has `return !HAS_GMCH(display)` =E2=80=94 i.= e., GMCH platforms *cannot* do deep color. This seems backwards. On modern i915 platforms (DISPLAY_VER >=3D 10 or so),= YCbCr444 output should be available, while GMCH platforms are unlikely to = support it. Unless there's something very specific about GMCH platforms tha= t makes them YCbCr444-only-capable, this needs verification or at minimum a= code comment explaining the reasoning. Only has Acked-by (not Reviewed-by) from Daniel Stone, suggesting less scru= tiny. --- Generated by Claude Code Patch Reviewer