From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: qcom: Pass proper PAS ID to set_remote_state API Date: Mon, 25 May 2026 18:55:31 +1000 Message-ID: In-Reply-To: <20260522115936.201208-12-sumit.garg@kernel.org> References: <20260522115936.201208-1-sumit.garg@kernel.org> <20260522115936.201208-12-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `qcom_pas_set_remote_state(resume, 0)` to pass the actual PAS ID instead of 0. **Commit message notes SCM ignores it while OP-TEE uses it**: This is a behavioral change for the SCM backend path too (the second argument to the SCM call changes from 0 to the actual PAS ID). The commit message says SCM ignores it, which should be verified. Looking at the SCM implementation, `set_remote_state` passes `args[1] = pas_id` to the SMC call. If the firmware truly ignores it, this is safe. Good change -- it's correct to pass the proper PAS ID. --- Generated by Claude Code Patch Reviewer