From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: use drm backlight Date: Thu, 04 Jun 2026 14:54:32 +1000 Message-ID: In-Reply-To: <20260531114908.1693426-12-superm1@kernel.org> References: <20260531114908.1693426-1-superm1@kernel.org> <20260531114908.1693426-12-superm1@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Mostly good** Clean integration following the same pattern as amdgpu. **Concern**: The `Assisted-by: Sonnet:4` tag in the commit message should p= robably be `Assisted-by: Claude Sonnet 4 ` or simila= r proper format, or dropped if the Intel maintainers don't want AI-assisted= tags. **Minor**: Same missing blank line issue as patch 8 between the backlight a= lloc block and the next if statement in `intel_dp_init_connector`. --- **Summary of critical issues to address before merge:** 1. Spinlock vs sleeping calls in `drm_backlight.c` =E2=80=94 needs to be a = mutex or refcounting deferred 2. Global property range clobbering across connectors =E2=80=94 needs per-c= onnector property instances 3. `drm_backlight_get_device` returns unprotected pointer =E2=80=94 needs r= efcount or different API 4. lockdep assertions called outside lock in register/unregister 5. `WARN_ON` on brightness set failure is too aggressive for production 6. Resume backlight restore path may be broken after cache removal --- Generated by Claude Code Patch Reviewer