From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Refactor CPU ioctl into unified submission chain Date: Thu, 04 Jun 2026 11:24:42 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-11-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-11-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Folds the indirect CSD path into the standard `struct v3d_submit` chain, eliminating the second `drm_exec` and the two-pass fence attachment. The CPU, CSD, and CLEAN_CACHE jobs all live in one `submit` instance. The `WARN_ON(submit.jobs[1]->queue != V3D_CSD)` assertion is a good safety check: ```c if (WARN_ON(submit.jobs[1]->queue != V3D_CSD)) { ret = -EINVAL; goto fail; } ``` Removes `clean_job` and `exec` fields from `struct v3d_indirect_csd_info`, cleaning up the data structures. No issues. --- Generated by Claude Code Patch Reviewer