From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vfs: remove kino_t typedef and PRIino format macro Date: Wed, 04 Mar 2026 08:15:04 +1000 Message-ID: In-Reply-To: <20260302-iino-u64-v2-110-e5388800dae0@kernel.org> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-110-e5388800dae0@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean removal of the scaffolding: ```c -typedef u64 kino_t; -#define PRIino "ll" ``` And the final type change: ```c - kino_t i_ino; + u64 i_ino; ``` The remaining `PRIino` uses in VFS core files are converted, and `(kino_t)0` becomes `(u64)0`. After this patch, there is no trace of the temporary typedef/macro. **Clean and correct.** --- **Summary**: The series is well-designed, correctly implements a long-desired type widening, and uses a sensible bisectability strategy. The mechanical changes are vast but straightforward. The few non-trivial changes (VFS hash functions, ext4 arithmetic, audit widening, sock widening, trace reordering) are handled correctly. The main areas that could benefit from minor attention are: (1) a comment on the hash truncation behavior on 32-bit, (2) `struct inode` / `struct sock` packing analysis on 32-bit, and (3) the `(unsigned int)` vs `(u32)` style nit in ext4. None of these are blockers. --- Generated by Claude Code Patch Reviewer