From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() Date: Wed, 11 Feb 2026 16:37:18 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-13-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-13-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Simplifies Exynos probe by using new helper, with special handling for display-timings. ```c + if (of_get_display_timings(dev->of_node)) { + dp->plat_data.next_bridge = devm_drm_of_display_mode_bridge(dp->dev, + dp->dev->of_node, + DRM_MODE_CONNECTOR_eDP); + if (IS_ERR(dp->plat_data.next_bridge)) + return PTR_ERR(dp->plat_data.next_bridge); + } ``` **Review:** - Handles legacy display-timings case before calling finish_probe - Conditional component_add based on whether panel/bridge was found - Removes temporary `has_of_bridge` flag (good) **Verdict:** Approved. --- --- Generated by Claude Code Patch Reviewer