public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks
@ 2026-02-16 20:45 Antheas Kapenekakis
  2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
                   ` (14 more replies)
  0 siblings, 15 replies; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Same as V1 with an additional four quirks. Also fixed indents on A1 Pro.
Contains various handhelds. If we can merge this great.

On top of torvalds/master.

---
V1: https://lore.kernel.org/lkml/20250904175025.3249650-1-lkml@antheas.dev/

Antheas Kapenekakis (14):
  drm: panel-orientation-quirks: Add AOKZOE A1 Pro
  drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021
  drm: panel-orientation-quirks: Add Ayaneo 3
  drm: panel-orientation-quirks: Add OneXPlayer X1 variants
  drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants
  drm: panel-orientation-quirks: Add OneXPlayer F1 variants
  drm: panel-orientation-quirks: Add OneXPlayer G1 variants
  drm: panel-orientation-quirks: Add GPD Win Max (2021)
  drm: panel-orientation-quirks: Add GPD Pocket 4
  drm: panel-orientation-quirks: Add Zeenix Lite and Pro
  drm: panel-orientation-quirks: add SuiPlay0X1
  drm: panel-orientation-quirks: Add OneXPlayer X1z
  drm: panel-orientation-quirks: Add AOKZOE A2 Pro
  drm: panel-orientation-quirks: Add OneXPlayer X1 Air

 .../gpu/drm/drm_panel_orientation_quirks.c    | 132 ++++++++++++++++++
 1 file changed, 132 insertions(+)


base-commit: 0f2acd3148e0ef42bdacbd477f90e8533f96b2ac
-- 
2.52.0



^ permalink raw reply	[flat|nested] 30+ messages in thread

* [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021 Antheas Kapenekakis
                   ` (13 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The AOKZOE A1 Pro has a portrait 16:10 panel, add a quirk for it.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3a218fb592ce..736280302f76 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -179,6 +179,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
 		},
 		.driver_data = (void *)&lcd720x1280_rightside_up,
+	}, {	/* AOKZOE A1 Pro */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AOKZOE"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AOKZOE A1 Pro"),
+		},
+		.driver_data = (void *)&lcd1200x1920_leftside_up,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
  2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3 Antheas Kapenekakis
                   ` (12 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The Ayaneo 2021 has an alternate variant that skips AYA in the
beginning. Add that as well.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 736280302f76..23e736469aab 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -215,6 +215,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* AYA NEO 2021 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "NEO 2021"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* AYA NEO AIR */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
  2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
  2026-02-16 20:45 ` [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021 Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants Antheas Kapenekakis
                   ` (11 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The Ayaneo 3 comes with two panels, an OLED right side up 1080p panel
and an IPS landscape 1080p panel. However, both have the same DMI data.
This quirk adds support for the portrait OLED panel.

As the landscape panel is 1920x1080 and the right side up panel is
1080x1920, the width and height arguments are used to differentiate
the panels.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 23e736469aab..f745db95c394 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -209,6 +209,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
 		},
 		.driver_data = (void *)&lcd1200x1920_rightside_up,
+	}, {	/* AYANEO 3 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 3"),
+		},
+		.driver_data = (void *)&lcd1080x1920_rightside_up,
 	}, {	/* AYA NEO 2021 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (2 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3 Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants Antheas Kapenekakis
                   ` (10 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The OneXPlayer X1 series features a 2k 10.95 display with a portrait
orientation. Add quirks to set the panel orientation to portrait mode
to the Intel, AMD, and EVA-02 variants.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 .../gpu/drm/drm_panel_orientation_quirks.c    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index f745db95c394..2efffe962460 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -504,6 +504,30 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
 		},
 		.driver_data = (void *)&lcd1200x1920_leftside_up,
+	}, {	/* OneXPlayer X1 AMD */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 A"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 Intel */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 AMD Strix Point */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Pro"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1Pro EVA variant with Intel */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Pro EVA-02"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (3 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants Antheas Kapenekakis
                   ` (9 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The OneXPlayer X1 mini features a 2k 8.8 display with a portrait
orientation. The Pro is a CPU refresh. Add quirks to set the panel
orientation to portrait mode. There is no Intel variant.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 2efffe962460..1ee66e4db0e9 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -516,6 +516,18 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 mini (AMD) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 mini pro (AMD Strix Point) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Mini Pro"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OneXPlayer X1 AMD Strix Point */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (4 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants Antheas Kapenekakis
                   ` (8 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The OneXPlayer F1Pro has a 144hz 1920x1080 portrait OLED panel.
Add a quirk to correct the panel portrait orientation. In addition,
it comes with a red limited edition variant in the Chinese market,
so add that as well. Then, add the 8840U non-pro variant as well.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 1ee66e4db0e9..af45d79622b5 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -540,6 +540,24 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Pro EVA-02"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) LE Red variant */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) Hawk Point */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 OLED"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {	/* OneXPlayer OneXFly F1 Pro (OLED) Strix Point */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1Pro"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (5 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021) Antheas Kapenekakis
                   ` (7 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Add quirks for the new clamshell device OneXPlayer G1 for both AMD
and Intel. The device has a 1600x2560p 144hz LCD panel.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index af45d79622b5..675a0aeb750e 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -558,6 +558,18 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1Pro"),
 		},
 		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {	/* OneXPlayer OneXFly G1 AMD */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER G1 A"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer OneXFly G1 Intel */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER G1 i"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021)
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (6 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4 Antheas Kapenekakis
                   ` (6 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Right side up, DSI-1, 800x1280 screen.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 675a0aeb750e..21ae8a811e2b 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -327,6 +327,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-01"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* GPD Win Max (2021) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-03"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/*
 		 * GPD Pocket, note that the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (7 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021) Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro Antheas Kapenekakis
                   ` (5 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

The GPD Pocket 4 is a mini laptop replacement with a portrait
2k panel. Add a quirk for it.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 21ae8a811e2b..8475811df890 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -388,6 +388,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
 		},
 		.driver_data = (void *)&lcd1080x1920_rightside_up,
+	}, {	/* GPD Pocket 4 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1628-04"),
+		},
+		.driver_data = (void *)&lcd1600x2560_rightside_up,
 	}, {	/* I.T.Works TW891 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (8 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4 Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1 Antheas Kapenekakis
                   ` (4 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Add quirks for two Zeenix handhelds, the Lite and the Pro.
They are identical to the Ayn Loki and the Ayn Loki Pro respectively.

Reviewed-by: Philip Müller <philm@manjaro.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 8475811df890..c055be8d8b25 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -594,6 +594,18 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galaxy Book 10.6"),
 		},
 		.driver_data = (void *)&lcd1280x1920_rightside_up,
+	}, {    /* Tectoy Zeenix Lite */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Tectoy"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Zeenix Lite"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {    /* Tectoy Zeenix Pro */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Tectoy"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Zeenix Pro"),
+		},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
 	}, {	/* Valve Steam Deck (Jupiter) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (9 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z Antheas Kapenekakis
                   ` (3 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Very similar to the AYANEO 2S, the Mysten SuiPlay0X1 is a handheld
gaming device with a 1200x1920 display that is mounted in a
right-side-up orientation. Add a quirk for it.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index c055be8d8b25..857fbc1ba4dc 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -491,6 +491,12 @@ static const struct dmi_system_id orientation_data[] = {
 		 DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"),
 		},
 		.driver_data = (void *)&lcd1600x2560_rightside_up,
+	}, {	/* Mysten SuiPlay0X1 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Mysten Labs, Inc."),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SuiPlay0X1"),
+		},
+		.driver_data = (void *)&lcd1200x1920_rightside_up,
 	}, {	/* Nanote UMPC-01 */
 		.matches = {
 		 DMI_MATCH(DMI_SYS_VENDOR, "RWC CO.,LTD"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (10 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1 Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro Antheas Kapenekakis
                   ` (2 subsequent siblings)
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Different variant of the OneXPlayer X1 AMD edition with an 8840U.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 857fbc1ba4dc..96c910d4524e 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -546,6 +546,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Mini Pro"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 AMD second variant */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1z"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OneXPlayer X1 AMD Strix Point */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (11 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 20:45 ` [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air Antheas Kapenekakis
  2026-02-16 21:19 ` Claude review: drm: panel-orientation-quirks: Add various handheld quirks Claude Code Review Bot
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

We are missing a quirk for this older device, so add it.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 96c910d4524e..6de137b5e777 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -185,6 +185,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AOKZOE A1 Pro"),
 		},
 		.driver_data = (void *)&lcd1200x1920_leftside_up,
+	}, {	/* AOKZOE A2 Pro */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AOKZOE"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AOKZOE A2 Pro"),
+		},
+		.driver_data = (void *)&lcd1200x1920_leftside_up,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (12 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro Antheas Kapenekakis
@ 2026-02-16 20:45 ` Antheas Kapenekakis
  2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
  2026-02-16 21:19 ` Claude review: drm: panel-orientation-quirks: Add various handheld quirks Claude Code Review Bot
  14 siblings, 1 reply; 30+ messages in thread
From: Antheas Kapenekakis @ 2026-02-16 20:45 UTC (permalink / raw)
  To: dri-devel
  Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Simona Vetter, philm, Antheas Kapenekakis

Special edition of the X1 with a new Intel chipset.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 6de137b5e777..b1915c1f92da 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -546,6 +546,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 mini"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer X1 Intel */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Air"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* OneXPlayer X1 mini pro (AMD Strix Point) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add various handheld quirks
  2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
                   ` (13 preceding siblings ...)
  2026-02-16 20:45 ` [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air Antheas Kapenekakis
@ 2026-02-16 21:19 ` Claude Code Review Bot
  14 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm: panel-orientation-quirks: Add various handheld quirks
Author: Antheas Kapenekakis <lkml@antheas.dev>
Patches: 15
Reviewed: 2026-02-17T07:19:39.491903

---

This is a 14-patch series adding panel orientation quirks for various handheld gaming devices and mini laptops to `drm_panel_orientation_quirks.c`. All 14 patches touch only this single file, each adding one or more DMI-based entries to the `orientation_data[]` table. The devices covered include AOKZOE, AYANEO, OneXPlayer, GPD, Zeenix (Tectoy), and Mysten SuiPlay handhelds.

The series is straightforward data-only work. Each patch adds a `dmi_system_id` entry with `DMI_EXACT_MATCH` on vendor and product name, pointing to an existing `drm_dmi_panel_orientation_data` struct. All referenced structs (`lcd800x1280_rightside_up`, `lcd1200x1920_leftside_up`, `lcd1080x1920_rightside_up`, `lcd1080x1920_leftside_up`, `lcd1600x2560_leftside_up`, `lcd1200x1920_rightside_up`, `lcd1600x2560_rightside_up`) are pre-existing and have correct width/height/orientation values. The width/height matching in `drm_get_panel_orientation_quirk()` means quirks only apply when the actual panel resolution matches, which is the correct safeguard for devices like the Ayaneo 3 that ship with two different panel types.

There are two issues worth noting: patch 10 (Zeenix) uses spaces instead of tabs in the entry separator lines, inconsistent with the rest of the file; and patch 14 (X1 Air) has a misleading comment that says "OneXPlayer X1 Intel" while the commit subject and DMI product name both reference "X1Air" / "X1 Air." Neither of these is a correctness bug, but the comment mismatch is worth fixing before merge. Patches 12-14 are missing Reviewed-by tags that the earlier patches have.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add AOKZOE A1 Pro
  2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds a quirk for the AOKZOE A1 Pro with `lcd1200x1920_leftside_up`. The entry is correctly placed alphabetically after the Anbernic Win600. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021
  2026-02-16 20:45 ` [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021 Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

> +	}, {	/* AYA NEO 2021 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "NEO 2021"),
> +		},
> +		.driver_data = (void *)&lcd800x1280_rightside_up,

Adds an alternate DMI identity for the Ayaneo 2021 where the product name is "NEO 2021" (vendor "AYANEO") rather than "AYA NEO 2021" (vendor "AYADEVICE"). The existing entry uses `lcd800x1280_rightside_up` and so does this one. Correctly placed. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add Ayaneo 3
  2026-02-16 20:45 ` [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3 Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

> +	}, {	/* AYANEO 3 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 3"),
> +		},
> +		.driver_data = (void *)&lcd1080x1920_rightside_up,

The commit message explains the Ayaneo 3 ships with two panel options (OLED portrait 1080x1920, IPS landscape 1920x1080) sharing the same DMI data. This approach works correctly because `drm_get_panel_orientation_quirk()` checks `data->width != width || data->height != height`, so the quirk only applies when the panel reports 1080x1920 (portrait), not 1920x1080 (landscape). Good commit message explaining the rationale. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add OneXPlayer X1 variants
  2026-02-16 20:45 ` [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds four entries for X1 AMD ("ONEXPLAYER X1 A"), X1 Intel ("ONEXPLAYER X1 i"), X1Pro Strix Point ("ONEXPLAYER X1Pro"), and X1Pro EVA-02 ("ONEXPLAYER X1Pro EVA-02"). All use `lcd1600x2560_leftside_up`. Correctly placed in the OneXPlayer section. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants
  2026-02-16 20:45 ` [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds two entries for X1 mini AMD ("ONEXPLAYER X1 mini") and X1 mini pro ("ONEXPLAYER X1Mini Pro"). Both use `lcd1600x2560_leftside_up`. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add OneXPlayer F1 variants
  2026-02-16 20:45 ` [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds three entries for the F1 EVA-02 LE Red variant, F1 OLED (Hawk Point), and F1Pro (Strix Point). All use `lcd1080x1920_leftside_up`. The commit message mentions "the 8840U non-pro variant" but the third entry comment says "F1 Pro (OLED) Strix Point" and matches product name "ONEXPLAYER F1Pro" -- the "non-pro" device appears to be the "ONEXPLAYER F1 OLED" entry. The wording is slightly confusing but functionally correct. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add OneXPlayer G1 variants
  2026-02-16 20:45 ` [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds two entries for the G1 AMD ("ONEXPLAYER G1 A") and G1 Intel ("ONEXPLAYER G1 i"). Both use `lcd1600x2560_leftside_up`. Placed between the F1 series and OrangePi Neo entries. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add GPD Win Max (2021)
  2026-02-16 20:45 ` [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021) Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds GPD Win Max 2021 ("G1619-03") with `lcd800x1280_rightside_up`, consistent with the existing GPD Win Max 2020 entry ("G1619-01") immediately above it. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add GPD Pocket 4
  2026-02-16 20:45 ` [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4 Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

> +	}, {	/* GPD Pocket 4 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1628-04"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_rightside_up,

The commit describes this as a "mini laptop replacement with a portrait 2k panel." Uses `lcd1600x2560_rightside_up` (right side up rather than left side up), which is different from the OneXPlayer 1600x2560 entries that use `leftside_up`. This is a device-specific physical orientation difference, not an error. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add Zeenix Lite and Pro
  2026-02-16 20:45 ` [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

> +	}, {    /* Tectoy Zeenix Lite */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Tectoy"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Zeenix Lite"),
> +		},
> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
> +	}, {    /* Tectoy Zeenix Pro */

Both Zeenix entries use 4 spaces between `}, {` and the comment (`}, {    /*`), while every other entry in the file uses a tab (`}, {^I/*`). This should be fixed to use tabs for consistency with the rest of the file.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: add SuiPlay0X1
  2026-02-16 20:45 ` [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1 Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds a quirk for the Mysten SuiPlay0X1 with `lcd1200x1920_rightside_up`. Commit message notes similarity to AYANEO 2S. Correctly placed in alphabetical order. The subject line uses lowercase "add" which is inconsistent with the rest of the series (all use uppercase "Add"), though this is cosmetic. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add OneXPlayer X1z
  2026-02-16 20:45 ` [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds a variant of the X1 AMD ("ONEXPLAYER X1z") with `lcd1600x2560_leftside_up`. Missing Reviewed-by tag that patches 1-10 have, but that's the author's prerogative. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add AOKZOE A2 Pro
  2026-02-16 20:45 ` [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

Adds AOKZOE A2 Pro with `lcd1200x1920_leftside_up`, same orientation as the A1 Pro from patch 1. Correctly placed alphabetically. Missing Reviewed-by tag. No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Claude review: drm: panel-orientation-quirks: Add OneXPlayer X1 Air
  2026-02-16 20:45 ` [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air Antheas Kapenekakis
@ 2026-02-16 21:19   ` Claude Code Review Bot
  0 siblings, 0 replies; 30+ messages in thread
From: Claude Code Review Bot @ 2026-02-16 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

> +	}, {	/* OneXPlayer X1 Intel */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Air"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,

The comment says "OneXPlayer X1 Intel" but the commit subject says "Add OneXPlayer X1 Air" and the DMI product name is "ONEXPLAYER X1Air". The commit message says "Special edition of the X1 with a new Intel chipset." The comment should say "OneXPlayer X1 Air" (or "OneXPlayer X1Air") to match the actual product name, not just "X1 Intel" -- there is already a separate "X1 Intel" entry from patch 4 that matches "ONEXPLAYER X1 i". Using the same comment text for two different devices would be confusing.

Additionally, this patch inserts the X1Air entry between "X1 mini" and "X1 mini pro", which is an odd position. It might make more sense next to the other X1 entries (X1 A, X1 i, X1Pro, X1Pro EVA-02).

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2026-02-16 21:19 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021) Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 21:19 ` Claude review: drm: panel-orientation-quirks: Add various handheld quirks Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox