From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: mm: Add common types for all page table formats Date: Fri, 27 Feb 2026 14:25:30 +1000 Message-ID: In-Reply-To: <20260224225323.3312204-13-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> <20260224225323.3312204-13-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean abstraction. The `MmuVersion::from(Architecture)` conversion currently only has v2 variants with a commented-out v3 fallback. This is fine for now. The `AperturePte::from(u8)` catch-all: ```rust _ => Self::VideoMemory, ``` Silently defaulting unknown values to `VideoMemory` could mask data corruption. Consider returning `Invalid` or panicking in debug builds. --- Generated by Claude Code Patch Reviewer