From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Add DOORBELL_BLOCK registers Date: Wed, 25 Mar 2026 07:08:45 +1000 Message-ID: In-Reply-To: <20260323-b4-tyr-use-register-macro-v3-v3-12-a87daf9e4701@collabora.com> References: <20260323-b4-tyr-use-register-macro-v3-v3-0-a87daf9e4701@collabora.com> <20260323-b4-tyr-use-register-macro-v3-v3-12-a87daf9e4701@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Simple and clean. The 64KiB stride (`0x10000`) for doorbell blocks is correct for page-aligned mapping. The `ring` field as a single-bit bool at bit 0 of a write-only register is appropriate for a doorbell. --- Generated by Claude Code Patch Reviewer