From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add SKU detection support for X2-85 Date: Wed, 25 Mar 2026 07:32:11 +1000 Message-ID: In-Reply-To: <20260324-a8xx-gpu-batch2-v1-12-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-12-fc95b8d9c017@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `ADRENO_QUIRK_SOFTFUSE` and a new CX_MISC register for soft-SKU detection on X2-85. **Issue:** The speedbin reading was moved out of `adreno_gpu_init()` into driver-specific init functions (a5xx, a6xx). The a5xx change adds the code that was previously in `adreno_gpu_init()`, but this means any other GPU family (a4xx?) that relied on the common code in `adreno_gpu_init()` would lose speedbin support. Verify no regressions for older GPUs. The new `a6xx_read_speedbin()` function properly falls back: first tries fuse, then soft-fuse via CX_MISC register if the SOFTFUSE quirk is set. --- Generated by Claude Code Patch Reviewer