From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Date: Tue, 31 Mar 2026 17:39:47 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-13-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-13-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Bug:** `drm_dp_dpcd_read_byte()` returns **0 on success**, not 1: ```c + if (drm_dp_dpcd_read_byte(&intel_dp->aux, + DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1, + &rx_features) == 1) { ``` This check will always be false (the function returns 0 on success, negative on error). The same issue applies to the second `drm_dp_dpcd_read_byte` call for `pr_caps`. This means `as_sdp_v2_supported` will never be set to true. Should be: ```c if (drm_dp_dpcd_read_byte(..., &rx_features) == 0) { ``` Note: the older `drm_dp_dpcd_readb()` API returned number of bytes read (1 on success), but `drm_dp_dpcd_read_byte()` returns 0 on success. The author likely confused the two APIs. No R-b tag. --- Generated by Claude Code Patch Reviewer