From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/color: Program plane YUV range correction colorop Date: Sun, 12 Apr 2026 13:07:25 +1000 Message-ID: In-Reply-To: <20260408051514.608781-13-chaitanya.kumar.borah@intel.com> References: <20260408051514.608781-1-chaitanya.kumar.borah@intel.com> <20260408051514.608781-13-chaitanya.kumar.borah@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Critical**: This patch adds lines 1303-1304 to `glk_plane_color_ctl()`: ```c plane_color_ctl |=3D plane_state->hw.yuv_range_correct ? 0 : PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE; ``` As noted in patch 3 review, this unconditionally disables YUV range correct= ion on all SDR planes when `yuv_range_correct` is false (the zero-initializ= ed default). This is a **regression for limited-range YUV content** that do= esn't use the color pipeline =E2=80=94 the legacy path at lines 1292-1293 w= ould correctly leave range correction enabled for limited-range, but this n= ew code overrides that by always setting the DISABLE bit. The intent is presumably that when using the color pipeline, userspace cont= rols range correction via the colorop bypass state. But the code runs uncon= ditionally for all SDR planes regardless of whether a color pipeline is act= ive. --- Generated by Claude Code Patch Reviewer