From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Date: Sun, 12 Apr 2026 11:37:41 +1000 Message-ID: In-Reply-To: <20260409065301.446670-13-damon.ding@rock-chips.com> References: <20260409065301.446670-1-damon.ding@rock-chips.com> <20260409065301.446670-13-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `analogix_dp_finish_probe()` which handles DP AUX bus population and panel/bridge parsing centrally. The key flow: 1. `devm_of_dp_aux_populate_bus()` is called with `analogix_dp_aux_done_probing` callback 2. If it returns `-ENODEV` (no EP devices), the callback is invoked directly 3. The callback does `drm_of_find_panel_or_bridge()` and then `component_add()` The `plat_data->ops` field is added to pass `component_ops` since the AUX bus callback only receives `drm_dp_aux`. The port number for `drm_of_find_panel_or_bridge()` is correctly differentiated: ```c int port = plat_data->dev_type == EXYNOS_DP ? 0 : 1; ``` Also selects `DRM_DISPLAY_DP_AUX_BUS` for `DRM_ANALOGIX_DP` in Kconfig. No issues. --- Generated by Claude Code Patch Reviewer