From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: net: ipa: Switch to generic PAS TZ APIs Date: Tue, 28 Apr 2026 14:49:25 +1000 Message-ID: In-Reply-To: <20260427095603.1157963-13-sumit.garg@kernel.org> References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-13-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean migration. Notably, IPA drops the `select QCOM_SCM` in favor of `select QCOM_PAS`. This means IPA no longer forces `QCOM_SCM` to be built in. Since the PAS abstraction will dispatch to whichever backend is registered, this is correct -- if only the TEE backend is used, QCOM_SCM isn't needed. The refactoring of the error-handling code in `ipa_firmware_load()` from the chained assignment inside `else if` to a cleaner `else { ret = ...; if (ret) ... }` is a nice cleanup. --- Generated by Claude Code Patch Reviewer