From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Date: Tue, 05 May 2026 10:35:03 +1000 Message-ID: In-Reply-To: <20260430110652.558622-13-vladimir.oltean@nxp.com> References: <20260430110652.558622-1-vladimir.oltean@nxp.com> <20260430110652.558622-13-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces `hdmi->phy->dev.of_node` access with a proper OF phandle lookup via `of_parse_phandle_with_args()`. The driver was using this to get the clock provider node for pixel clock validation on RK3328. The new code: ```c index = of_property_match_string(np, "phy-names", "hdmi"); if (index >= 0) { of_parse_phandle_with_args(np, "phys", "#phy-cells", index, &clkspec); ``` This is cleaner API usage and properly calls `of_node_put()` to release the reference. No issues. --- Generated by Claude Code Patch Reviewer