From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: qcom: Pass proper PAS ID to set_remote_state API
Date: Tue, 05 May 2026 08:22:46 +1000 [thread overview]
Message-ID: <review-patch12-20260504130603.1474043-13-sumit.garg@kernel.org> (raw)
In-Reply-To: <20260504130603.1474043-13-sumit.garg@kernel.org>
Patch Review
Changes the PAS ID argument from `0` to the actual PAS ID for both iris and venus:
```c
- return qcom_pas_set_remote_state(resume, 0);
+ return qcom_pas_set_remote_state(resume, core->iris_platform_data->pas_id);
```
The commit message explains the SCM backend ignores the value while OP-TEE uses it. This is a behavioral change for the SCM path but is safe since the backend ignores it. Good that this is in its own patch for bisectability.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 13:05 [PATCH v5 00/16] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-05-04 13:05 ` [PATCH v5 01/16] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 02/16] firmware: qcom: Add a generic PAS service Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 03/16] firmware: qcom_scm: Migrate to " Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 04/16] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 05/16] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 06/16] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 07/16] soc: qcom: mdtloader: " Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 08/16] remoteproc: qcom_wcnss: " Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 09/16] remoteproc: qcom: Select QCOM_PAS generic service Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 10/16] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 11/16] media: qcom: " Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:05 ` [PATCH v5 12/16] media: qcom: Pass proper PAS ID to set_remote_state API Sumit Garg
2026-05-04 22:22 ` Claude Code Review Bot [this message]
2026-05-04 13:06 ` [PATCH v5 13/16] net: ipa: Switch to generic PAS TZ APIs Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:06 ` [PATCH v5 14/16] wifi: ath12k: " Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:06 ` [PATCH v5 15/16] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 13:06 ` [PATCH v5 16/16] MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Sumit Garg
2026-05-04 22:22 ` Claude review: " Claude Code Review Bot
2026-05-04 22:22 ` Claude review: firmware: qcom: Add OP-TEE PAS service support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch12-20260504130603.1474043-13-sumit.garg@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox