From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: dw_hdmi: Use generic CEC notifier helpers
Date: Tue, 05 May 2026 07:58:57 +1000
Message-ID: <review-patch12-20260504191059.275928-13-jonas@kwiboo.se>
In-Reply-To: <20260504191059.275928-13-jonas@kwiboo.se>
References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-13-jonas@kwiboo.se>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Replaces open-coded CEC notifier handling with the `drm_hdmi_cec_helper.h` =
API (`drm_connector_cec_phys_addr_invalidate`, `drm_connector_cec_phys_addr=
_set`, `drmm_connector_hdmi_cec_notifier_register`). Using `drmm_` managed =
registration means the `bridge_detach` callback for CEC cleanup is no longe=
r needed.

```c
+	select DRM_DISPLAY_HDMI_CEC_NOTIFIER_HELPER
```

The Kconfig `select` is correct =E2=80=94 `DRM_DW_HDMI_CEC` needs the helpe=
r. Looks correct overall. **No Reviewed-by yet.**

---
Generated by Claude Code Patch Reviewer