From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Split BO fence attach from syncobj output handling Date: Sat, 16 May 2026 15:59:29 +1000 Message-ID: In-Reply-To: <20260510-v3d-sched-misc-fixes-v2-12-ca4aba343ef6@igalia.com> References: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> <20260510-v3d-sched-misc-fixes-v2-12-ca4aba343ef6@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean decomposition of `v3d_attach_fences_and_unlock_reservation()` into: 1. `v3d_submit_attach_object_fences()` =E2=80=94 BO fence attachment 2. `v3d_submit_unlock_reservations()` =E2=80=94 drm_exec cleanup 3. `v3d_submit_process_post_deps()` =E2=80=94 syncobj output handling Both (1) and (2) are folded into `v3d_submit_jobs()`, so callers only need = to call `v3d_submit_process_post_deps()` afterward. **Observation on v3d_submit_jobs() control flow**: After this patch, on suc= cess, `v3d_submit_jobs()` unlocks reservations before returning. On error (= the `err:` label), it does *not* unlock reservations, leaving that to the c= aller. The callers all have `fail_unreserve:` labels that call `v3d_submit_= unlock_reservations()`. This is correct but asymmetric =E2=80=94 patch 14 r= esolves this by having the error path also unlock. No issues. --- Generated by Claude Code Patch Reviewer