From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/crtc: Add new atomic_create_state callback Date: Sat, 16 May 2026 13:22:54 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-12-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-12-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Same pattern as patch 10 but for CRTCs. Notably, `drm_mode_config_crtc_crea= te_state()` calls `drm_crtc_vblank_reset()` after creating the state =E2=80= =94 this is important because `__drm_atomic_helper_crtc_reset()` does this,= and the cover letter explicitly mentions not putting it in the `create_sta= te` callback itself (since that must be side-effect-free). Minor nit: the doc comment has a double space: `"Allocates and initializes= "`. Otherwise no issues. --- Generated by Claude Code Patch Reviewer