From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Use dw_hdmi_connector_status_update() Date: Mon, 18 May 2026 16:41:47 +1000 Message-ID: In-Reply-To: <20260516183838.2024991-13-jonas@kwiboo.se> References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-13-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Correct. The key change: EDID is now read in `detect()` and `force()` instead of `get_modes()`. This matches bridge connector behavior. The `dw_hdmi_connector_status_update()` function now handles connected vs disconnected differently: ```c + if (status == connector_status_disconnected) { + drm_edid_connector_update(connector, NULL); + cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); + return; + } ``` The `get_modes()` is simplified to just `return drm_edid_connector_add_modes(connector)` since EDID is already cached. --- Generated by Claude Code Patch Reviewer