From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: net: ipa: Switch to generic PAS TZ APIs
Date: Mon, 25 May 2026 18:55:32 +1000
Message-ID: <review-patch12-20260522115936.201208-13-sumit.garg@kernel.org>
In-Reply-To: <20260522115936.201208-13-sumit.garg@kernel.org>
References: <20260522115936.201208-1-sumit.garg@kernel.org> <20260522115936.201208-13-sumit.garg@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Clean conversion of the IPA driver. Also improves code style by splitting the `else if` with embedded assignment into separate statements:
```c
// Before:
else if ((ret = qcom_scm_pas_auth_and_reset(IPA_PAS_ID)))
// After:
} else {
    ret = qcom_pas_auth_and_reset(IPA_PAS_ID);
    if (ret)
```
This is a good cleanup -- assignments inside conditionals are discouraged.

**Kconfig changes from `select QCOM_SCM` to `select QCOM_PAS`**: The IPA driver no longer uses any SCM APIs directly after this patch, so dropping `QCOM_SCM` is correct.

No issues.

---
Generated by Claude Code Patch Reviewer