From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/crtc: Add new atomic_create_state callback Date: Wed, 27 May 2026 14:30:51 +1000 Message-ID: In-Reply-To: <20260526-drm-mode-config-init-v6-12-852346394200@kernel.org> References: <20260526-drm-mode-config-init-v6-0-852346394200@kernel.org> <20260526-drm-mode-config-init-v6-12-852346394200@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Mirrors the plane pattern for CRTCs. The `drm_mode_config_crtc_create_state()` helper also calls `drm_crtc_vblank_reset()` if the device has vblank support, which matches what `__drm_atomic_helper_crtc_reset()` does. Good. Minor doc nit: double space in "Allocates and initializes" in `drm_atomic_helper_crtc_create_state()`. --- Generated by Claude Code Patch Reviewer