From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Date: Wed, 11 Feb 2026 16:37:18 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-14-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-14-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Centralizes next bridge attachment in core instead of platform drivers. ```c - if (dp->plat_data->attach) { - ret = dp->plat_data->attach(dp->plat_data, bridge); + if (dp->plat_data->next_bridge) { + ret = drm_bridge_attach(dp->encoder, dp->plat_data->next_bridge, bridge, + DRM_BRIDGE_ATTACH_NO_CONNECTOR); ``` **Review:** - Removes another callback (attach) - Standardizes attachment behavior - Removes ~20 lines of duplicated platform code **Verdict:** Excellent consolidation. --- --- Generated by Claude Code Patch Reviewer