From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: staging: media: tegra-video: tegra20: expand format support with RAW8/10 and YUV422/YUV420p 1X16
Date: Wed, 04 Mar 2026 07:48:08 +1000 [thread overview]
Message-ID: <review-patch13-20260303084239.15007-14-clamor95@gmail.com> (raw)
In-Reply-To: <20260303084239.15007-14-clamor95@gmail.com>
Patch Review
Adds Bayer RAW8/RAW10 and 1X16 YUV variants. RAW formats use `TEGRA_VI_OUT_2` while YUV continues to use `TEGRA_VI_OUT_1`. The output format selection logic in `tegra20_camera_capture_setup`:
```c
enum tegra_vi_out output_channel = (data_type == TEGRA_IMAGE_DT_RAW8 ||
data_type == TEGRA_IMAGE_DT_RAW10) ?
TEGRA_VI_OUT_2 : TEGRA_VI_OUT_1;
```
This is clean and consistent across the VIP start_streaming function as well.
**No issues.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 21:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:42 [PATCH v7 00/15] tegra-video: add CSI support for Tegra20 and Tegra30 Svyatoslav Ryhel
2026-03-03 8:42 ` [PATCH v7 01/15] staging: media: tegra-video: expand VI and VIP support to Tegra30 Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 02/15] staging: media: tegra-video: vi: adjust get_selection operation check Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 03/15] staging: media: tegra-video: vi: add flip controls only if no source controls are provided Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 04/15] staging: media: tegra-video: csi: move CSI helpers to header Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 05/15] gpu: host1x: convert MIPI to use operation function pointers Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 06/15] staging: media: tegra-video: vi: improve logic of source requesting Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 07/15] staging: media: tegra-video: csi: move avdd-dsi-csi-supply from VI to CSI Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 08/15] staging: media: tegra-video: tegra20: set correct maximum width and height Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 09/15] staging: media: tegra-video: tegra20: add support for second output of VI Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 10/15] staging: media: tegra-video: tegra20: adjust format align calculations Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 11/15] staging: media: tegra-video: tegra20: set VI HW revision Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 12/15] staging: media: tegra-video: tegra20: increase maximum VI clock frequency Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 13/15] staging: media: tegra-video: tegra20: expand format support with RAW8/10 and YUV422/YUV420p 1X16 Svyatoslav Ryhel
2026-03-03 21:48 ` Claude Code Review Bot [this message]
2026-03-03 8:42 ` [PATCH v7 14/15] staging: media: tegra-video: tegra20: adjust luma buffer stride Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 8:42 ` [PATCH v7 15/15] staging: media: tegra-video: add CSI support for Tegra20 and Tegra30 Svyatoslav Ryhel
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
2026-03-03 21:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch13-20260303084239.15007-14-clamor95@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox