From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Convert to atomic_create_state Date: Wed, 11 Mar 2026 13:09:09 +1000 Message-ID: In-Reply-To: <20260310-drm-mode-config-init-v1-13-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> <20260310-drm-mode-config-init-v1-13-de7397c8e1cf@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean conversion. The crtc reset callback is converted to `atomic_create_state` and the plane switches to the helper. The conversion properly: - Returns `ERR_PTR(-ENOMEM)` on allocation failure instead of silently leaving `crtc->state = NULL` - Uses `__drm_atomic_helper_crtc_create_state()` instead of `__drm_atomic_helper_crtc_reset()` - Removes the old state destruction from the callback (since create_state should only be for pristine states) --- Generated by Claude Code Patch Reviewer