From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Date: Tue, 10 Mar 2026 11:39:09 +1000 Message-ID: In-Reply-To: <20260310012458.169272-14-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> <20260310012458.169272-14-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `analogix_dp_finish_probe()` which combines panel/bridge parsing with component addition via DP AUX bus. The API correctly handles the `-ENODEV` case from `devm_of_dp_aux_populate_bus()`. ```c ret = drm_of_find_panel_or_bridge(dp->dev->of_node, port, 0, &plat_data->panel, &plat_data->next_bridge); if (ret && ret != -ENODEV) return ret; return component_add(dp->dev, plat_data->ops); ``` This is clean. The port selection (`EXYNOS_DP ? 0 : 1`) correctly handles the different DT bindings. `DRM_DISPLAY_DP_AUX_BUS` is properly selected in Kconfig. Note that `analogix_dp_finish_probe` is added here but **not yet used** by Rockchip or Exynos - that's patches 14 and 15 (not in the mbox). Looking at the final Rockchip source, it appears patch 14 was applied correctly (Rockchip uses its own `rockchip_dp_link_panel` callback). However the **Exynos side (patch 15) appears not to have been applied** - `exynos_dp_probe()` still calls `component_add()` directly rather than `analogix_dp_finish_probe()`, perpetuating the `next_bridge` clobbering bug from patch 5. ### PATCHES 14-18 (not in mbox, inferred from cover letter and final state) The remaining patches were truncated from the mbox. Based on the cover letter: - **Patch 14**: Apply `analogix_dp_finish_probe()` for Rockchip - appears applied correctly. - **Patch 15**: Apply `analogix_dp_finish_probe()` for Exynos - appears **not applied** in the final state (exynos_dp.c still uses direct `component_add`). - **Patch 16**: Attach next bridge in `analogix_dp_bridge_attach()` - not verifiable from final state. - **Patch 17**: Remove bridge disabling/panel unpreparing in unbind - the final state still has `analogix_dp_bridge_disable()` and `drm_panel_unprepare()` in `analogix_dp_unbind()`, so this patch may not have been applied either. - **Patch 18**: Apply panel_bridge helper. --- Generated by Claude Code Patch Reviewer