From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Add helper for AS SDP transmission time selection Date: Thu, 12 Mar 2026 06:55:30 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-14-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-14-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `intel_dp_as_sdp_transmission_time()` which always returns `DP_PR_AS_SDP_SETUP_TIME_T1`, and `get_pr_alpm_as_sdp_transmission_time()` to translate it to hardware register values. **Design concern:** `intel_dp_as_sdp_transmission_time()` takes no parameters and always returns T1. This is essentially a constant masquerading as a function. A `#define` or an inline returning a constant would be clearer. The commit message says "future PR/AS SDP modes/features may require T2 or dynamic selection" but designing for hypothetical requirements adds unnecessary indirection. Also, the `crtc_state` parameter to `get_pr_alpm_as_sdp_transmission_time()` is unused. --- Generated by Claude Code Patch Reviewer