From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/color: Add YUV range correction to SDR plane pipeline Date: Sun, 12 Apr 2026 13:07:25 +1000 Message-ID: In-Reply-To: <20260408051514.608781-14-chaitanya.kumar.borah@intel.com> References: <20260408051514.608781-1-chaitanya.kumar.borah@intel.com> <20260408051514.608781-14-chaitanya.kumar.borah@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall**: Simple one-liner adding `INTEL_PLANE_CB_YUV_RANGE_CORRECT` at = the front of the SDR pipeline: ```c static const enum intel_color_block sdr_plane_pipeline[] =3D { INTEL_PLANE_CB_YUV_RANGE_CORRECT, INTEL_PLANE_CB_PRE_CSC_LUT, INTEL_PLANE_CB_CSC_FF, INTEL_PLANE_CB_POST_CSC_LUT, }; ``` The ordering (range correction =E2=86=92 pre-CSC LUT =E2=86=92 CSC =E2=86= =92 post-CSC LUT) matches the hardware pipeline and is logically correct: l= imited-to-full range expansion must happen before the CSC that expects full= -range input. No issues. --- **Summary of required fixes:** 1. **Must fix**: `glk_plane_color_ctl()` needs mutual exclusion between leg= acy and colorop-based CSC/range-correction paths. The colorop path should o= nly apply when a color pipeline is active on the plane, and the legacy path= should be skipped in that case. Without this, the series introduces a regr= ession for existing YUV content on SDR planes and a corruption bug when bot= h paths activate simultaneously. 2. **Should fix**: Replace `plane - 3` magic number with a derived value or= named constant, and add a defensive WARN_ON. 3. **Should fix**: Kernel-doc `@DRM_COLOROP_FM_YCBCR2020_NC_FULL_RGB` =E2= =86=92 `@DRM_COLOROP_FM_YCBCR2020_FULL_RGB_NC`. 4. **Consider**: Move patch 5 (bug fix) to the beginning of the series and = submit it independently for stable backport, separate from the feature patc= hes. --- Generated by Claude Code Patch Reviewer