From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Use revision field of AS SDP data structure Date: Sun, 12 Apr 2026 12:51:27 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-14-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-14-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **R-b: Ville Syrjala** Moves the AS SDP revision from hardcoded `0x02` to `as_sdp->revision`, sets it during compute, and reads it back during unpack. Also adds `revision` to the comparison function. The removal of the revision check in unpack is notable: ```c - if (sdp->sdp_header.HB2 != 0x02) - return -EINVAL; ``` This makes the unpack accept any revision, which is necessary for forward compatibility but means the driver won't reject AS SDPs with unknown revisions during readback verification. This is reasonable since the purpose of the readback is comparison with what was programmed, not validation. No issues. --- Generated by Claude Code Patch Reviewer