From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dp: introduce stream_id for each DP panel
Date: Sun, 12 Apr 2026 10:16:14 +1000
Message-ID: <review-patch13-20260410-msm-dp-mst-v4-13-b20518dea8de@oss.qualcomm.com>
In-Reply-To: <20260410-msm-dp-mst-v4-13-b20518dea8de@oss.qualcomm.com>
References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-13-b20518dea8de@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Unnecessary NULL check after container_of()**:
```c
+	dp =3D container_of(msm_dp_display, struct msm_dp_display_private, msm_dp=
_display);
+
+	if (!dp) {
+		DRM_ERROR("invalid input\n");
+		return -EINVAL;
+	}
```
`container_of()` performs pointer arithmetic =E2=80=94 it will never return=
 NULL (unless the input itself is NULL, which would make the container_of r=
esult non-NULL anyway, just a garbage pointer). This check is dead code and=
 should be removed.

---
Generated by Claude Code Patch Reviewer