From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: wifi: ath12k: Switch to generic PAS TZ APIs Date: Tue, 28 Apr 2026 14:49:25 +1000 Message-ID: In-Reply-To: <20260427095603.1157963-14-sumit.garg@kernel.org> References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-14-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean migration. The error message fix from `"scm pas shutdown failed for userPD%d\n"` to `"pas shutdown failed for userPD%d: %d\n"` adds the `ret` value but note that `ret` is not actually passed as a format argument in the `ath12k_err()` call: ```c ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n", ab_ahb->userpd_id); ``` This is a **format string mismatch bug** -- the format has `%d: %d` (two arguments) but only one argument (`ab_ahb->userpd_id`) is passed. This will print garbage for the second `%d`. The `ret` variable should be added as the second argument. --- Generated by Claude Code Patch Reviewer