From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: net: ipa: Switch to generic PAS TZ APIs Date: Tue, 05 May 2026 08:22:46 +1000 Message-ID: In-Reply-To: <20260504130603.1474043-14-sumit.garg@kernel.org> References: <20260504130603.1474043-1-sumit.garg@kernel.org> <20260504130603.1474043-14-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Migrates the IPA driver. The Kconfig changes from `select QCOM_SCM` to `select QCOM_PAS` -- this is correct since IPA doesn't use any other SCM APIs. Also cleans up an `else if` assignment-in-conditional into a cleaner style: ```c - else if ((ret = qcom_scm_pas_auth_and_reset(IPA_PAS_ID))) - dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); + } else { + ret = qcom_pas_auth_and_reset(IPA_PAS_ID); + if (ret) + dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); + } ``` Good style improvement. No issues. --- --- Generated by Claude Code Patch Reviewer