From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Reject invalid out_sync handles in submit ioctls
Date: Sat, 16 May 2026 15:59:30 +1000
Message-ID: <review-patch13-20260510-v3d-sched-misc-fixes-v2-13-ca4aba343ef6@igalia.com>
In-Reply-To: <20260510-v3d-sched-misc-fixes-v2-13-ca4aba343ef6@igalia.com>
References: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> <20260510-v3d-sched-misc-fixes-v2-13-ca4aba343ef6@igalia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Mirrors patch 6's treatment of in_sync for the out_sync path. Previously, a=
 non-zero invalid `out_sync` handle was silently ignored. Now, `drm_syncobj=
_find()` is done up-front and returns `-ENOENT` on failure.

`v3d_put_multisync_post_deps()` is generalized into `v3d_submit_put_post_de=
ps()` which handles both the single-sync case (`sync_out`) and multi-sync c=
ase (`se->out_syncs`).

**Same UAPI note as patch 6**: Userspace passing invalid non-zero `out_sync=
` handles will now get `-ENOENT` instead of silent success. Correct behavio=
r, potential compat concern if buggy userspace exists.

**Minor observation**: The early return paths for `sync_out` lookup failure=
 happen before any job allocation, so there's no cleanup needed =E2=80=94 t=
his is correct:
```c
if (args->out_sync && !(se.flags & DRM_V3D_EXT_ID_MULTI_SYNC)) {
    sync_out =3D drm_syncobj_find(file_priv, args->out_sync);
    if (!sync_out)
        return -ENOENT;
}
```

No issues.

---
Generated by Claude Code Patch Reviewer