From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: vesafb: fix memory leak in vesafb_probe()
Date: Sat, 16 May 2026 11:10:43 +1000
Message-ID: <review-patch13-20260514-fbdev-v1-13-b3a2474fa720@cse.iitm.ac.in>
In-Reply-To: <20260514-fbdev-v1-13-b3a2474fa720@cse.iitm.ac.in>
References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> <20260514-fbdev-v1-13-b3a2474fa720@cse.iitm.ac.in>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Correct**

```c
 vesafb_setup(option);
+kfree(option);
```

Same analysis as patch 12. `vesafb_setup()` also uses `strsep()` on a local=
 copy, so `option` still points to the original buffer. Safe to free.

Note the comment `/* ignore error return of fb_get_options */` =E2=80=94 ev=
en if `fb_get_options()` "fails" (returns 1), it still sets `*option` to `N=
ULL` (or a kstrdup'd string). `kfree(NULL)` is a no-op, so this is safe in =
all paths.

---

---
Generated by Claude Code Patch Reviewer